-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Stricter permission/condition fallback mechanism for isGranted
#461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mathias Scherer <[email protected]>
refactor: simplifications
heueristik
force-pushed
the
feature/refactored-permission-manager
branch
from
September 19, 2023 13:24
defbd8d
to
0ec32c2
Compare
heueristik
changed the title
feature: refactored permission manager
feature: Stricter permission/condition fallback mechanism for Sep 19, 2023
isGranted
heueristik
force-pushed
the
feature/refactored-permission-manager
branch
from
September 21, 2023 08:31
8409e56
to
2e9f55d
Compare
mathewmeconry
previously approved these changes
Sep 21, 2023
heueristik
dismissed
mathewmeconry’s stale review
September 21, 2023 09:15
The base branch was changed.
…-permission-manager
Rekard0
approved these changes
Sep 21, 2023
Rekard0
previously approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mathewmeconry
suggested changes
Sep 21, 2023
Co-authored-by: Mathias Scherer <[email protected]>
Rekard0
approved these changes
Sep 21, 2023
mathewmeconry
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the fallback functionality ( two logical ORs
||
)from
isGranted
inPermissionManager
as it could lead to unintuitive behavior.The new behavior is as follows (excerpt from the docs):
As a bonus, we save gas by, for example, not calling
(2)
and(3)
if(1)
already answeredfalse
.Task: OS-710
Type of change
Checklist:
CHANGELOG.md
file in the root folder.DEPLOYMENT_CHECKLIST
file in the root folder.UPDATE_CHECKLIST
file in the root folder.