Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong import, missing await, incorrect comment #526

Merged
merged 3 commits into from
Feb 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/contracts/hardhat.config.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import networks, {ContractsNetworkConfig} from './networks';
import {AragonPluginRepos, TestingFork} from './utils/types';
import {AragonPluginRepos, TestingFork} from './types/hardhat';
import {NetworkConfigs} from '@aragon/osx-commons-configs';
import '@nomicfoundation/hardhat-chai-matchers';
import '@nomicfoundation/hardhat-network-helpers';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -498,7 +498,7 @@ contract PluginSetupProcessor is ProtocolVersion {

/// @notice Applies the permissions of a prepared update of an UUPS upgradeable proxy contract to a DAO.
/// @param _dao The address of the updating DAO.
/// @param _params The struct containing the parameters for the `applyInstallation` function.
/// @param _params The struct containing the parameters for the `applyUpdate` function.
function applyUpdate(
address _dao,
ApplyUpdateParams calldata _params
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ describe('ENSSubdomainRegistrar', function () {

it('reverts if the approval of the registrar is removed', async () => {
// Initialize the registrar with the 'test' domain
registrar.initialize(
await registrar.initialize(
managingDao.address,
ens.address,
ensDomainHash('test')
Expand Down
Loading