Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use common mocks and token calls generators #527

Merged
merged 9 commits into from
Feb 16, 2024
Merged

feat: use common mocks and token calls generators #527

merged 9 commits into from
Feb 16, 2024

Conversation

josemarinas
Copy link
Contributor

@josemarinas josemarinas commented Jan 31, 2024 •
edited by jira bot
Loading

Description

Use createDummyAction and Token calls generator from the @aragon/osx-commons-subgraph

Task ID: OS-999

Type of change

See the framework lifecylce in packages/contracts/docs/framework-lifecycle to decide what kind of change this pull request is.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.

heueristik
heueristik reviewed Feb 1, 2024
View reviewed changes
Copy link
Contributor

@heueristik heueristik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I've left some minor comments.

Thanks for removing the redundant imports along the way.
Let's also remove redundant code/comments where we see them.

heueristik
heueristik previously approved these changes Feb 1, 2024
View reviewed changes
@heueristik
Copy link
Contributor

One typo left

jordaniza
jordaniza reviewed Feb 5, 2024
View reviewed changes
Copy link
Contributor

@jordaniza jordaniza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly echo the comments from Sarkawt. Added some minor other comments

packages/subgraph/tests/admin/admin.test.ts Outdated Show resolved Hide resolved
packages/subgraph/tests/dao/dao_v1_3_0.test.ts Outdated Show resolved Hide resolved
jordaniza
jordaniza previously approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@jordaniza jordaniza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move to avoiding use of magic numbers and repeated names over time but other than that the PR looks good from what I can see.

packages/subgraph/tests/dao/dao_v1_3_0.test.ts Show resolved Hide resolved
Rekard0
Rekard0 previously approved these changes Feb 14, 2024
View reviewed changes
heueristik
heueristik suggested changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@heueristik heueristik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the merge conflict in the yarn.lock file

yarn.lock Outdated Show resolved Hide resolved
jordaniza
jordaniza approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@jordaniza jordaniza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@josemarinas josemarinas merged commit 1f4aa06 into develop Feb 16, 2024
16 checks passed
@josemarinas josemarinas deleted the f/OS-999-use-common-mocks branch February 16, 2024 14:18
@clauBv23 clauBv23 mentioned this pull request Apr 10, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heueristik heueristik heueristik approved these changes

@jordaniza jordaniza jordaniza approved these changes

@Rekard0 Rekard0 Rekard0 left review comments

Assignees
No one assigned
Labels
subgraph
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@josemarinas @heueristik @Rekard0 @jordaniza