Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update documentation workflow #558

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

clauBv23
Copy link
Contributor

@clauBv23 clauBv23 commented Mar 26, 2024

Description

This PR updates the documentation-updated workflow to define the alchemy key in the workflow env

Review

To check the change works properly needed to run the workflow and it only runs when pushing to develop. To avoid pushing not-tested code to develop in the commit 11485f9 added the current branch to force the workflow to run.
The workflow running successfuly can be seen here

Task ID: OS-1166

Type of change

See the framework lifecylce in packages/contracts/docs/framework-lifecycle to decide what kind of change this pull request is.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.
  • I have updated the Subgraph and added a QA URL to the description of this PR.

@clauBv23 clauBv23 merged commit 7faed0d into develop Mar 27, 2024
3 checks passed
@clauBv23 clauBv23 deleted the fix/workflow-for-update-documentation branch March 27, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants