Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/subgraph changes only #560

Merged
merged 4 commits into from
Apr 12, 2024
Merged

Feat/subgraph changes only #560

merged 4 commits into from
Apr 12, 2024

Conversation

novaknole
Copy link
Contributor

@novaknole novaknole commented Mar 28, 2024

Description

Only includes files that have changed on develop compared to main branch. This is to ensure that we still have the latest subgraph on main.

Please, see the file changes very carefully. Also, yarn.lock contains lots of changes which you might find it surprising. The yarn.lock looks like this because it contains everything from main branch's yarn lock + current branch's yarn.lock. Would be also good to go through with it just to be safe.

Task ID: OS-1180

QA: https://subgraphs.alchemy.com/subgraphs/984/versions/16039

Type of change

See the framework lifecylce in packages/contracts/docs/framework-lifecycle to decide what kind of change this pull request is.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.
  • I have updated the Subgraph and added a QA URL to the description of this PR.

@novaknole novaknole marked this pull request as draft March 28, 2024 13:07
@novaknole novaknole changed the base branch from develop to main March 28, 2024 13:09
@Rekard0 Rekard0 marked this pull request as ready for review April 3, 2024 09:39
jordaniza
jordaniza previously approved these changes Apr 5, 2024
Copy link
Contributor

@jordaniza jordaniza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've read every file but haven't done a manual diff. This looks sensible but once we merge we should pull and run a test locally just to be sure.

@Rekard0 Rekard0 requested a review from heueristik April 8, 2024 09:14
Copy link
Contributor

@Rekard0 Rekard0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is missing is the QA url.
please deploy the subgraph and provide the playground link as QA

@Rekard0 Rekard0 dismissed jordaniza’s stale review April 10, 2024 09:21

QA test is missing

@novaknole novaknole merged commit 014cd00 into main Apr 12, 2024
15 checks passed
@novaknole novaknole deleted the feat/subgraph-changes-only branch April 12, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants