Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: added reinitializer and storage gap to PluginRepo and moved events to IPluginRepo #584

Merged
merged 13 commits into from
May 10, 2024

Conversation

josemarinas
Copy link
Contributor

@josemarinas josemarinas commented Apr 30, 2024

Description

  • is upgradeable, but it doesn’t have a storage gap
  • Why are the events VersionCreated and ReleaseMetadataUpdated in PluginRepo and not in the IPluginRepo Interface?
    • we can move the events to the right place without changing the ERC-165 interface ID and updating the PluginRepoFactory
  • We miss a test checking that function updateReleaseMetadata emits the ReleaseMetadataUpdated event
  • Add an initializeFrom function to the contract. (see )
    • check on DAO.sol how this function is supposed to work
    • if we don’t need to re-initialize, then this function will be empty for now.

Task ID: OS-676

Type of change

See the framework lifecycle in packages/contracts/docs/framework-lifecycle to decide what kind of change this pull request is.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.
  • I have updated the Subgraph and added a QA URL to the description of this PR.

@josemarinas josemarinas marked this pull request as draft April 30, 2024 08:28
@josemarinas josemarinas marked this pull request as ready for review May 2, 2024 10:46
@heueristik heueristik changed the title chore(contracts): refactor PluginRepo refactor: added reinitializer and storage gap to PluginRepo and moved events to IPluginRepo May 2, 2024
@Rekard0 Rekard0 marked this pull request as draft May 3, 2024 10:06
@josemarinas josemarinas marked this pull request as ready for review May 6, 2024 13:16
heueristik
heueristik previously approved these changes May 6, 2024
Copy link
Contributor

@heueristik heueristik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jordaniza
jordaniza previously approved these changes May 8, 2024
@josemarinas josemarinas dismissed stale reviews from jordaniza and heueristik via 9df2235 May 9, 2024 06:57
@josemarinas josemarinas merged commit 1743e85 into develop May 10, 2024
17 checks passed
@josemarinas josemarinas deleted the f/OS-676-refactor-plugin-repo branch May 10, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants