Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove Docs from OSx Repo #595

Merged
merged 10 commits into from
May 17, 2024
Merged

chore: Remove Docs from OSx Repo #595

merged 10 commits into from
May 17, 2024

Conversation

banasa44
Copy link
Contributor

@banasa44 banasa44 commented May 14, 2024

Description

This PR has the complete removal of OSx hand-written documentation from OSx. With its necessary changes in the workflows.

It also adds a checkbox in the PR template so from now on, anyone who makes important changes in the OSx repo should create a follow-up task to reflect those changes in the Developer Portal.

At the end, there are some orthographic corrections in the Lifecycle .md files.

Please take a close look into the GitHub files, and see at the end if the orthographic corrections are correct.

Task ID: OS-1352

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.
  • I have updated the Subgraph and added a QA URL to the description of this PR.

Copy link
Contributor

@heueristik heueristik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure the version is correct

.github/pull_request_template.md Outdated Show resolved Hide resolved
@banasa44 banasa44 requested a review from heueristik May 16, 2024 07:13
clauBv23
clauBv23 previously approved these changes May 17, 2024
@banasa44 banasa44 merged commit 42704e2 into develop May 17, 2024
17 checks passed
@banasa44 banasa44 deleted the fix/docs-for-dev-portal branch May 17, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants