-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Extended PM with permission owner and delegation capabilities #604
Open
nivida
wants to merge
94
commits into
develop
Choose a base branch
from
feature/extended-pm
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
novaknole
reviewed
Aug 29, 2024
novaknole
reviewed
Aug 29, 2024
novaknole
reviewed
Aug 29, 2024
novaknole
reviewed
Aug 29, 2024
novaknole
reviewed
Aug 29, 2024
novaknole
reviewed
Aug 29, 2024
novaknole
reviewed
Aug 29, 2024
novaknole
reviewed
Aug 29, 2024
novaknole
reviewed
Aug 29, 2024
novaknole
reviewed
Aug 29, 2024
novaknole
reviewed
Aug 29, 2024
novaknole
reviewed
Aug 29, 2024
novaknole
reviewed
Aug 29, 2024
novaknole
reviewed
Aug 29, 2024
novaknole
reviewed
Aug 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1st Round ^_^
…ssionOwner to ownerAuth
Co-authored-by: Claudia Barcelo <[email protected]>
Co-authored-by: Claudia Barcelo <[email protected]>
Co-authored-by: Claudia Barcelo <[email protected]>
Co-authored-by: Claudia Barcelo <[email protected]>
Co-authored-by: Claudia Barcelo <[email protected]>
Co-authored-by: Claudia Barcelo <[email protected]>
Co-authored-by: Claudia Barcelo <[email protected]>
Co-authored-by: Claudia Barcelo <[email protected]>
Co-authored-by: Claudia Barcelo <[email protected]>
Co-authored-by: Claudia Barcelo <[email protected]>
Co-authored-by: Claudia Barcelo <[email protected]>
Co-authored-by: Claudia Barcelo <[email protected]>
Co-authored-by: Claudia Barcelo <[email protected]>
Co-authored-by: Claudia Barcelo <[email protected]>
Co-authored-by: Claudia Barcelo <[email protected]>
Co-authored-by: Claudia Barcelo <[email protected]>
clauBv23
reviewed
Sep 17, 2024
* fix more tests and cleaner * test fixes + permissionFrozen for multi target + more fixes * improve natspec
* fix: remove .only * fix: 63/64 rule tests * feat: add tests for undelegate function * fix typechain coverage * fix: tets * feat: add couple of tests --------- Co-authored-by: Giorgi Lagidze <[email protected]>
* fix pm contract wiwth tests * Update packages/contracts/src/core/permission/PermissionManager.sol Co-authored-by: Claudia Barcelo <[email protected]> * Update packages/contracts/src/core/permission/PermissionManager.sol Co-authored-by: Claudia Barcelo <[email protected]> * Update packages/contracts/test/core/permission/permission-manager.ts Co-authored-by: Claudia Barcelo <[email protected]> * add extra tests for delegation * fix checkOwner for delegation * separate tests * more gas efficient approach * efficient gas approach + fix removeOwner with tests * add more tests --------- Co-authored-by: Claudia Barcelo <[email protected]>
* executor interface * add tests for iexecutor * test * action import free level * Update packages/contracts/test/framework/dao/dao-factory.ts Co-authored-by: Claudia Barcelo <[email protected]> * comments removed --------- Co-authored-by: Claudia Barcelo <[email protected]>
* fix tests and typechain + loop * remove comments * add back vscode files * interface fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and be sure you follow the contributions rules we do provide here
Task ID: OS-?
Type of change
See the framework lifecycle in
packages/contracts/docs/framework-lifecycle
to decide what kind of change this pull request is.Checklist:
CHANGELOG.md
file in the root folder.DEPLOYMENT_CHECKLIST
file in the root folder.UPDATE_CHECKLIST
file in the root folder.