Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export Erc721TokenDetailsinterface #170

Closed
wants to merge 1 commit into from

Conversation

pythonpete32
Copy link
Contributor

fixes #169

Description

exports the Erc721TokenDetails

Task: ID

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before the latest version.
  • I have tested my code on the test network.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.6% 1.6% Duplication

@brickpop
Copy link
Contributor

brickpop commented Mar 9, 2023

Hi @pythonpete32, thank you for your contribution.
Support for managing NFT's is not complete yet on the SDK, so exporting this type might not entire solve #169. We can leave this PR open and use it as as the base for the final solution

@pythonpete32
Copy link
Contributor Author

ahhh gotcha!

heueristik
heueristik previously approved these changes Sep 1, 2023
@heueristik heueristik dismissed their stale review September 1, 2023 08:54

Outdated PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: @aragon/sdk-client dose not export Erc721TokenDetails
3 participants