Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New DataType module #695

Open
wants to merge 14 commits into
base: clinicadl_v2
Choose a base branch
from

Conversation

camillebrianceau
Copy link
Collaborator

@camillebrianceau camillebrianceau commented Jan 3, 2025

Summary of Changes:

  • Updated the API files with the new data module.
  • Introduced a new module data.datatype with three submodules (modalities, preprocessing, and raw). This will help differentiate:
    • ImageModality (e.g., PET, T1w, etc.),
    • RawData (providing the file types of a BIDS dataset),
    • Preprocessing (e.g., T1Linear, DWIDTI, FlairLinear, etc.) which gives the file type corresponding to the Clinica pipeline's CAPS output.
  • Added corresponding unit tests for the new functionality.

Architecture Overview:
This architecture is a beginning and a pre-module, but it will later be replaced with ClinicaIO. The goal is to structure the data management system around different concepts, such as ImageModality, RawData, and Preprocessing, and provide clear mappings between them.

I am not entirely sure that the architecture and the names are the best, so feel free to suggest any changes and give feedback!

dependabot bot and others added 14 commits January 2, 2025 15:21
Bumps [sqlparse](https://github.com/andialbrecht/sqlparse) from 0.4.4 to 0.5.0.
- [Changelog](https://github.com/andialbrecht/sqlparse/blob/master/CHANGELOG)
- [Commits](andialbrecht/sqlparse@0.4.4...0.5.0)

---
updated-dependencies:
- dependency-name: sqlparse
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [mlflow](https://github.com/mlflow/mlflow) from 2.10.1 to 2.12.1.
- [Release notes](https://github.com/mlflow/mlflow/releases)
- [Changelog](https://github.com/mlflow/mlflow/blob/master/CHANGELOG.md)
- [Commits](mlflow/mlflow@v2.10.1...v2.12.1)

---
updated-dependencies:
- dependency-name: mlflow
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [gunicorn](https://github.com/benoitc/gunicorn) from 21.2.0 to 22.0.0.
- [Release notes](https://github.com/benoitc/gunicorn/releases)
- [Commits](benoitc/gunicorn@21.2.0...22.0.0)

---
updated-dependencies:
- dependency-name: gunicorn
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* try a simple workflow first

* try running on new ubuntu VM

* fixes

* bump poetry version to 1.8.3

* try removing caching..

* add workflow for testing tsv tools
* try skipping test_tsvtools when PR is in draft mode

* trigger CI

* add a cpu tag to avoid running cpu tests on gpu machines

* run also on refactoring branch
Bumps [certifi](https://github.com/certifi/python-certifi) from 2024.2.2 to 2024.7.4.
- [Commits](certifi/python-certifi@2024.02.02...2024.07.04)

---
updated-dependencies:
- dependency-name: certifi
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* drop python 3.8

* do not recommend Python 3.8 in docs

* do not test with python 3.8

* update requests

* bump python version in environment.yml
* support Python 3.12

* run unit tests on Python 3.12

* update dependencies to be compatible with 3.12

* bump torch

* use np.prod instead of np.product which was removed in Numpy 2
@camillebrianceau camillebrianceau marked this pull request as ready for review January 3, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants