Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump: upgrade actions version #852

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

bump: upgrade actions version #852

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
815692e
bump: upgrade actions version
baerwang Sep 26, 2024
c86c4e7
bump: actions cache version upgrade
baerwang Sep 26, 2024
b49bea4
fix: According to review dog changed code
baerwang Sep 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/changelog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
name: auto generate changelog
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 0

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/codeql-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:

steps:
- name: Checkout repository
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
# We must fetch at least the immediate parents so that if this is
# a pull request then we can checkout the head.
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docker-image.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v4
- name: Docker meta
id: meta
uses: docker/metadata-action@v3
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/go-integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,12 @@ jobs:
os:
- ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-go@v3
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
Comment on lines +43 to +44
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Action Required: Update actions/cache to the latest version.

The workflow currently uses actions/cache@v3, which should be updated to the latest version to ensure compatibility and security. Please update the actions/cache action to the most recent stable release.

  • Update line with actions/cache@v3 to actions/cache@v4 (or the latest available version).
🔗 Analysis chain

LGTM! Approved changes to GitHub Actions versions.

The updates to actions/checkout@v4 and actions/setup-go@v5 are appropriate and align with the PR objectives. These upgrades are crucial for maintaining compatibility and security, especially considering the upcoming end-of-life for Actions running on Node.js 16.

To ensure the changes don't introduce any unexpected issues, please verify that the workflow runs successfully after merging this PR. You can do this by:

  1. Merging the PR to a test branch
  2. Manually triggering the workflow on the test branch
  3. Checking the workflow results for any failures or unexpected behavior
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that no other action versions need updating in this workflow

# Test: Check for any remaining v2 or v3 actions in the file
rg --type yaml 'uses: actions/.*@v[23]' .github/workflows/go-integration.yml

# Note: If this returns any results, consider updating those actions as well.

Length of output: 109

with:
go-version: ${{ matrix.go_version }}
- run: go version
- uses: actions/cache@v3
- uses: actions/cache@v4
with:
path: |
~/.cache/go-build
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/go.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,12 @@ jobs:
os:
- ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-go@v3
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: ${{ matrix.go_version }}
- run: go version
- uses: actions/cache@v3
- uses: actions/cache@v4
with:
path: |
~/.cache/go-build
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/licence-checker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
check-license:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4

- name: Check License Header
uses: apache/skywalking-eyes@main
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/linelint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,6 @@ jobs:
name: Check if all files end in newline
steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v4
- name: Linelint
uses: fernandrone/[email protected]
Comment on lines 30 to 31
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider updating the linelint action version.

While updating the actions/checkout action, it's worth checking if there's a newer version of the fernandrone/linelint action available. The current version (0.0.4) might be outdated.

To check for updates and potentially upgrade the linelint action, you can:

  1. Visit the fernandrone/linelint GitHub repository to check for the latest release.
  2. If a newer version is available, update the version number in the workflow file.

For example, if a newer version (e.g., 0.1.0) is available, you could update it like this:

  - name: Linelint
-   uses: fernandrone/[email protected]
+   uses: fernandrone/[email protected]

Make sure to review the changelog for any breaking changes before updating.

Committable suggestion was skipped due to low confidence.

2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
goos: windows

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- uses: wangyoucao577/[email protected]
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/reviewdog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Check out code into the Go module directory
uses: actions/checkout@v3
uses: actions/checkout@v4

- uses: reviewdog/action-golangci-lint@v2
with:
Expand All @@ -48,9 +48,9 @@ jobs:
pull-requests: write
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- uses: actions/setup-go@v3
- uses: actions/setup-go@v5
with:
go-version: "1.20"
Comment on lines +53 to 55
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Action Required: Update Go Version in Workflow

The workflow is currently using Go version 1.20, while the latest available version is 1.23.1. It's recommended to update the Go version to the latest stable release to benefit from the latest features and security updates.

  • Update the go-version in .github/workflows/reviewdog.yml to "1.23.1".
🔗 Analysis chain

Approved: Update to actions/setup-go@v5 with a suggestion

This update aligns with the PR objective and brings the action to the latest version.

Please review the changelog for any new features or breaking changes: https://github.com/actions/setup-go/blob/main/CHANGELOG.md

Also, verify if Go 1.20 is still the desired version for this project. You might want to consider updating to a more recent version if applicable.

To check the latest Go version and compare with the one used in the workflow, run:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check the latest Go version and compare with the one in the workflow
latest_go_version=$(curl -sSL https://golang.org/VERSION?m=text | cut -c 3-)
workflow_go_version=$(grep -oP 'go-version: "\K[^"]+' .github/workflows/reviewdog.yml)

echo "Latest Go version: $latest_go_version"
echo "Workflow Go version: $workflow_go_version"

if [ "$latest_go_version" != "$workflow_go_version" ]; then
  echo "Consider updating the Go version in the workflow to $latest_go_version"
fi

Length of output: 606


Expand Down
Loading