Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce ARBORX_VERSION #1190

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Introduce ARBORX_VERSION #1190

wants to merge 1 commit into from
+2 −0

Conversation

aprokop
Copy link
Contributor

@aprokop aprokop commented Nov 13, 2024

I realized we didn't have an easy way for users to enable/disable code based on ArborX version.

@aprokop aprokop added the enhancement New feature or request label Nov 13, 2024
aprokop
aprokop commented Nov 13, 2024
View reviewed changes
CMakeLists.txt
@@ -100,6 +100,7 @@ install(EXPORT ArborXTargets
DESTINATION ${CMAKE_INSTALL_DATADIR}/cmake/ArborX
)

set(ARBORX_VERSION "10799")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I chose the simplest version. I understand that there's an opportunity to desync with ARBORX_VERSION_STRING, but I think it would be an overkill to introduce something heavier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rombur Rombur Rombur approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aprokop @Rombur