Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requirements.txt and correct workflow triggers #87

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

webbnh
Copy link
Contributor

@webbnh webbnh commented Aug 30, 2024

Changes introduced with this PR

Since the requirements.txt file is generated during the build, there is no need to commit it to the repo. Moreover, doing so distracts the Renovate bot, making maintenance harder and occasionally awkward. This PR removes it from the repo so that new plugins created from this template won't acquire this useless file.

This PR also tweaks the workflow triggers so that they trigger for pull request updates, updates to the main branch and for tag creations, and not for updates to any upstream branch. This will avoid the CI running twice when a PR refers to an upstream branch.


By contributing to this repository, I agree to the contribution guidelines.

@webbnh webbnh self-assigned this Aug 30, 2024
@webbnh webbnh merged commit 8d006fc into main Sep 3, 2024
3 checks passed
@webbnh webbnh deleted the remove-requiremets.txt branch September 3, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants