Replace the wait_queue data structure VecQueue with a linked list #184
+106
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guoweikang
force-pushed
the
guoweikang/use_list
branch
2 times, most recently
from
7b76e04
to
db2bc87
Compare
guoweikang
requested review from
equation314,
hky1999,
aarkegz and
Azure-stars
hky1999
reviewed
Oct 16, 2024
hky1999
reviewed
Oct 16, 2024
hky1999
reviewed
Oct 16, 2024
hky1999
reviewed
Oct 16, 2024
hky1999
reviewed
Oct 17, 2024
modules/axtask/src/run_queue.rs
Outdated
| pub fn blocked_resched( | ||
| &mut self, | ||
| mut wq_guard: WaitQueueGuard, | ||
| curr_waiter: Arc<WaitTaskNode>, |
There was a problem hiding this comment.
It still seems awkward, curr_waiter is just a wrapper for crate::current() in this code block.
There was a problem hiding this comment.
Here need param waiter, because wq_guard have to push back the curr wrapper , we can't crteate the wrapper in blocked_resched, because waiter fast delete in caller, need use it; we can discuss whether there is a better way
There was a problem hiding this comment.
6219d10 in this commit, give a plan remove wq_guard and waiter
guoweikang
force-pushed
the
guoweikang/use_list
branch
3 times, most recently
from
6219d10
to
1f46842
Compare
equation314
reviewed
Oct 18, 2024
guoweikang
force-pushed
the
guoweikang/use_list
branch
from
1f46842
to
b2e6261
Compare
-------- 1 use Rawlist for wait queue 2 fix mutex size after wait_queue modify 3 add unit test for axsync/mutex size Note: must use an unique &T as rawlist node Signed-off-by: guoweikang <[email protected]>
guoweikang
force-pushed
the
guoweikang/use_list
branch
from
b6cb9f7
to
2c8f9fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Replace branch with the official version number