Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved Apache Nginx clarity #334

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Improved Apache Nginx clarity #334

merged 1 commit into from
Apr 13, 2023

Conversation

ekansa
Copy link
Collaborator

@ekansa ekansa commented Apr 13, 2023

brief description of changes

Minor update on the Apache + Ngnix documentation to respond to @mradamcox suggestions

issues addressed

#267 (comment)

further comments

This box must be checked

  • the PR branch was originally made from the base branch

This box should be checked

  • after these changes the docs build locally without error

This box should only be checked you intend to follow through on it (we can do it on our end too)

  • I will cherry-pick all commits in this PR into other branches that should have them after this PR is merged

mradamcox
mradamcox approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@mradamcox mradamcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@ekansa ekansa merged commit 2f5c6c4 into master Apr 13, 2023
@ekansa ekansa deleted the nginx_rev_m branch April 13, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mradamcox mradamcox mradamcox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ekansa @mradamcox