Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds pre-commit hooks #30

Merged
merged 5 commits into from
Jun 12, 2024
Merged

Adds pre-commit hooks #30

merged 5 commits into from
Jun 12, 2024

Conversation

johnatawnclementawn
Copy link
Member

No description provided.

@johnatawnclementawn
Copy link
Member Author

johnatawnclementawn commented Jun 12, 2024

Hey @chrabyrd - @jacobtylerwalls and I were stubbing our toes on failing tests. It looks like CI is caching the dev dependencies which were being changed here (not picking up the addition of the helper that allows prettier and eslint to play nicely).
It seems like there are a handful of options - one is to point to a specific commit hash on the dev-dependencies branch (as I've done here). The other could be to add an npm cache clean to the GH action, but we tested that locally and it didn't seem to help.

@chrabyrd
Copy link
Contributor

Hey @chrabyrd - @jacobtylerwalls and I were stubbing our toes on failing tests. It looks like CI is caching the dev dependencies which were being changed here (not picking up the addition of the helper that allows prettier and eslint to play nicely). It seems like there are a handful of options - one is to point to a specific commit hash on the dev-dependencies branch (as I've done here). The other could be to add an npm cache clean to the GH action, but we tested that locally and it didn't seem to help.

@johnatawnclementawn could this be a package-lock.json issue? I don't love the idea of de-standardizing package.json just to make a test runner pass. I'd rather find a solution instead of a workaround, that way if this happens with developers out in the wild we have an answer for them.

package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@chrabyrd chrabyrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@chrabyrd chrabyrd merged commit 7e1514c into main Jun 12, 2024
6 checks passed
@chrabyrd chrabyrd deleted the add_pre_commit branch June 12, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants