Implement new base-root.htm template #38
Conversation
|
👀 |
|
|
|
👋 @jacobtylerwalls I'm bouncing this back to you, the tsconfig/frontend stuff is fixed but now the tests are failing with: |
|
Great! Test is now just failing on something substantive, looks like an out-of-date graph constant. I'll ask @johnatawnclementawn to take a look in #40, suggest merging this anyway to unblock things. |
…rches-rdm into jtw/fix-aliasing
| @@ -145,6 +144,7 @@ | |||
| "corsheaders", | |||
| "oauth2_provider", | |||
| "django_celery_results", | |||
| "arches_references", | |||
There was a problem hiding this comment.
Don't we want this above arches since it's an arches application?
There was a problem hiding this comment.
it doesn't matter, as long as arches.app is at the bottom
There was a problem hiding this comment.
I thought that was only true for templates, not css/img discovery.
There was a problem hiding this comment.
( oooO maybe not...arches.app only ever has templates, not media/build/...)
There was a problem hiding this comment.
just tested with an image and the results are as you'd expect ( project -> apps -> core ), but happy to chat if you'd like
There was a problem hiding this comment.
Okay, I'm with you now. I forgot how specialized we made ArchesApplicationsStaticFilesFinder, which even if there's an "arches" in the middle of INSTALLED_APPS, there won't be anything under arches/media, so this should be A-OK.
There was a problem hiding this comment.
@jacobtylerwalls @chrabyrd back from the future - arches_references has to go above arches because there are commands in arches_references/packages.py that need to be included in the packages options. I'll fix as part of #53
Closes #3