Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TS pre-commit hook #51

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Fix TS pre-commit hook #51

merged 1 commit into from
Aug 14, 2024

Conversation

jacobtylerwalls
Copy link
Member

Partner to archesproject/arches#11250.

To test, merge this branch into #39, and try commenting out the if (!token) { ... block of getToken() in api.ts. You shouldn't be able to commit that change. Without these changes, the commit goes through because the hook wasn't firing.

Copy link
Member

@johnatawnclementawn johnatawnclementawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍🏼 Thanks for the repro instructions

@johnatawnclementawn johnatawnclementawn merged commit 6d637ad into main Aug 14, 2024
6 checks passed
@johnatawnclementawn johnatawnclementawn deleted the jtw/fix-ts-hook branch August 14, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants