-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement front-end routes #11 #52
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All in all looks good, just a few minor things.
Also wanted to touch base on folder hierarchy ( yet again 😄 ). IMO components
should live outside of pages
. Happy to chat about it though
}, | ||
"nodeModulesPaths": { | ||
"arches": "archesproject/arches#dev/8.0.x", | ||
"vue-router": "^4.4.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't feel very strongly about this yet, but I could see vue-router
going into dev/8.0.x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For sure, let's cross that bridge when we need to.
51b9c73
to
3044673
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
7bfd4a6
to
c11894d
Compare
3044673
to
cdc8f12
Compare
Closes #11
PR currently based off #39