Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement front-end routes #11 #52

Merged
merged 7 commits into from
Aug 14, 2024
Merged

Implement front-end routes #11 #52

merged 7 commits into from
Aug 14, 2024

Conversation

jacobtylerwalls
Copy link
Member

  • Adds frontend routes and hello-world components for them to render to
  • Guards all but the login route behind a redirect to the login page
  • Forwards the user to the originally requested route post-auth
  • Adds lazy routes

Closes #11

PR currently based off #39

@jacobtylerwalls jacobtylerwalls linked an issue Aug 13, 2024 that may be closed by this pull request
Copy link
Contributor

@chrabyrd chrabyrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in all looks good, just a few minor things.

Also wanted to touch base on folder hierarchy ( yet again 😄 ). IMO components should live outside of pages. Happy to chat about it though

arches_lingo/src/arches_lingo/constants.ts Outdated Show resolved Hide resolved
arches_lingo/src/arches_lingo/constants.ts Outdated Show resolved Hide resolved
},
"nodeModulesPaths": {
"arches": "archesproject/arches#dev/8.0.x",
"vue-router": "^4.4.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel very strongly about this yet, but I could see vue-router going into dev/8.0.x

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sure, let's cross that bridge when we need to.

Copy link
Contributor

@chrabyrd chrabyrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Base automatically changed from jtw/login-form to main August 14, 2024 22:00
@jacobtylerwalls jacobtylerwalls merged commit fd59880 into main Aug 14, 2024
5 of 6 checks passed
@jacobtylerwalls jacobtylerwalls deleted the jtw/router branch August 14, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Vue routing
2 participants