create sidenav #14 #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
jacobtylerwalls
approved these changes
Aug 19, 2024
Comment on lines
43
to
49
| style=" | ||
| font-family: sans-serif; | ||
| height: 100vh; | ||
| width: 100vw; | ||
| display: flex; | ||
| flex-direction: column; | ||
| " |
There was a problem hiding this comment.
Without this in root.htm:
{% block body_attributes %}style="margin: 0"{% endblock %}
I get 8px of margin, causing scrolls (because I'm a pest and I configure MacOS to have Show Scroll bars > Always):
There was a problem hiding this comment.
OH! this is fixed by archesproject/arches#11343. I've added it manually to my local and have been developing against it 👍
There was a problem hiding this comment.
Hmm, I tried that and it didn't help but I'll check again tomorrow maybe I botched the build.
There was a problem hiding this comment.
no need to wait for me, let's merge 👌
…ithub.com/archesproject/arches-rdm into 56-cbyrd-application-does-not-retain-user
…oject/arches-rdm into 56-cbyrd-application-does-not-retain-user
…ot-retain-user fixes user retention #56
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.