Improve RDM to Lingo migration #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
approved these changes
Aug 22, 2024
| this.selectedLoadEvent = params.selectedLoadEvent || ko.observable(); | ||
| this.formatTime = params.formatTime; | ||
| this.timeDifference = params.timeDifference; | ||
| this.activeTab = params.activeTab || ko.observable(); | ||
| this.editHistoryUrl = `${arches.urls.edit_history}?transactionid=${ko.unwrap(params.selectedLoadEvent)?.loadid}`; | ||
|
|
||
| this.getSchemes = function(){ | ||
| self.loading(true); | ||
| self.submit('get_schemes').then(function(response){ |
There was a problem hiding this comment.
It's not worth polishing right now, just noting this should probably be a GET, not a POST. If you think the ETLManagerView needs to make this easier to accomplish that could be a core arches enhancement.
|
|
||
| concepts_nodegroup_lookup, concepts_nodes = self.get_graph_tree( | ||
| CONCEPTS_GRAPH_ID | ||
| ) | ||
| concepts_node_lookup = self.get_node_lookup(concepts_nodes) | ||
| self.etl_concepts(cursor, concepts_nodegroup_lookup, concepts_node_lookup) | ||
| # Prefetch concept hierarchy to avoid building it multiple times | ||
| concept_hierarchy, concepts_to_migrate = self.build_concept_hierarchy( |
There was a problem hiding this comment.
Nice. Also not worth polishing, but you can store this on self to stop having to pass it around.
arches_lingo/templates/views/components/etl_modules/migrate-to-lingo.htm
Outdated
Show resolved
Hide resolved
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #68
You should be able to review this by: