Add concept to reference dt node migration #24 #28
Conversation
| ) | ||
| ) | ||
|
|
||
| REFERENCE_SELECT_WIDGET = Widget.objects.get(name="reference-select-widget") |
There was a problem hiding this comment.
Wondering if we should make this more resilient against widget renames. Should we use id? Or just filter on datatype and use the hardcoded one if present else an aribtrary one?
There was a problem hiding this comment.
Good point, but I think for now it's okay. Currently the reference select widget handles both single and multi-select. The forecasts for folding other core datatypes into Arches-References are far away - I say we cross this bridge when we get there.
| @@ -82,6 +105,8 @@ def handle(self, *args, **options): | |||
| overwrite=options["overwrite"], | |||
| preferred_sort_language=psl, | |||
| ) | |||
| elif options["operation"] == "migrate_concept_nodes_to_reference_datatype": | |||
| self.migrate_concept_nodes_to_reference_datatype(options["graph"]) | |||
|
|
|||
| def migrate_collections_to_controlled_lists( | |||
There was a problem hiding this comment.
Out of scope for this PR, but I just ran into a case sensitivity thing, so it might have been nicer to do a looser match, e.g. value__lower__in=collections_to_migrate and then on the python side lower() everything in collections_to_migrate.
| management.call_command( | ||
| "controlled_lists", | ||
| operation="migrate_concept_nodes_to_reference_datatype", | ||
| graph="b974103f-73bb-4f2a-bffb-8303227ba0da", |
There was a problem hiding this comment.
As a follow-up ticket we could accept slugs, but not now. 👍
jacobtylerwalls
deleted the
24_script_migration_concept_to_reference_nodes
branch
Resolves #24
Should be preceded by #26 ✅