Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add primevue 4.1 compat #39

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Add primevue 4.1 compat #39

merged 3 commits into from
Oct 21, 2024

Conversation

jacobtylerwalls
Copy link
Member

  • Remove ugly workaround for lazy filtering on labels in selected language
  • Cope with primevue 4.1 class name change

Testing instructions

  • Save labels in multiple languages
  • Switch the "show labels in:" language selection inside the tree
  • Label filtering should still search on the selected language
  • Bolding of search results still works

@jacobtylerwalls jacobtylerwalls force-pushed the jtw/remove-tree-label-getter-workaround branch from 1d22470 to 0c18bf9 Compare October 7, 2024 17:24
johnatawnclementawn
johnatawnclementawn approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@johnatawnclementawn johnatawnclementawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@johnatawnclementawn johnatawnclementawn merged commit fcdb8e7 into main Oct 21, 2024
5 checks passed
@johnatawnclementawn johnatawnclementawn deleted the jtw/remove-tree-label-getter-workaround branch October 21, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnatawnclementawn johnatawnclementawn johnatawnclementawn approved these changes

Assignees

@johnatawnclementawn johnatawnclementawn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobtylerwalls @johnatawnclementawn