Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ingest string values and perform listitem lookup #40 #41

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Ingest string values and perform listitem lookup #40 #41

merged 4 commits into from
Oct 10, 2024

Conversation

johnatawnclementawn
Copy link
Member

Resolves #40

jacobtylerwalls
jacobtylerwalls requested changes Oct 9, 2024
View reviewed changes
Copy link
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. I have some comments; will give this a functional test when the changes are in.

arches_references/datatypes/datatypes.py Outdated Show resolved Hide resolved
arches_references/datatypes/datatypes.py Outdated Show resolved Hide resolved
arches_references/datatypes/datatypes.py Outdated Show resolved Hide resolved
arches_references/datatypes/datatypes.py Outdated Show resolved Hide resolved
arches_references/datatypes/datatypes.py Outdated Show resolved Hide resolved
arches_references/datatypes/datatypes.py Outdated Show resolved Hide resolved
arches_references/models.py Outdated Show resolved Hide resolved
arches_references/models.py Outdated Show resolved Hide resolved
arches_references/datatypes/datatypes.py Show resolved Hide resolved
arches_references/models.py Show resolved Hide resolved
@jacobtylerwalls jacobtylerwalls removed their assignment Oct 9, 2024
jacobtylerwalls
jacobtylerwalls approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@johnatawnclementawn johnatawnclementawn merged commit d1b37d4 into main Oct 10, 2024
5 checks passed
@johnatawnclementawn johnatawnclementawn deleted the 40_handle_reference_dt_label_lookups branch October 10, 2024 21:02
@johnatawnclementawn johnatawnclementawn mentioned this pull request Oct 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobtylerwalls jacobtylerwalls jacobtylerwalls approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle label lookup when creating new reference datatype
2 participants
@johnatawnclementawn @jacobtylerwalls