swap negative check of dict for postivie, re #11583

archesproject · Nov 1, 2024 · 07fb6d6 · 07fb6d6
1 parent 9007af9
commit 07fb6d6
Showing 1 changed file with 10 additions and 7 deletions.
diff --git a/arches/app/models/resource.py b/arches/app/models/resource.py
@@ -902,15 +902,18 @@ def get_relations(
                 and str(resourceinstancefrom_graphid) in readable_graphids
             ):
                 try:
-                    if f'{relation["relationshiptype"]}{lang}' not in preflabel_lookup:
+                    if f'{relation["relationshiptype"]}{lang}' in preflabel_lookup:
+                        preflabel = preflabel_lookup[
+                            f'{relation["relationshiptype"]}{lang}'
+                        ]
+                    else:
+                        preflabel = get_preflabel_from_valueid(
+                            relation["relationshiptype"], lang
+                        )
                         preflabel_lookup[f'{relation["relationshiptype"]}{lang}'] = (
-                            get_preflabel_from_valueid(
-                                relation["relationshiptype"], lang
-                            )
+                            preflabel
                         )
-                    preflabel = preflabel_lookup[
-                        f'{relation["relationshiptype"]}{lang}'
-                    ]
+
                     relation["relationshiptype_label"] = preflabel["value"] or ""
                 except:
                     relation["relationshiptype_label"] = (