Include a nodegroup's graph as nodegroup.graphid #11397
Draft
+52
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whatisgalen
changed the title
…p_graphid_fk merges latest from dev/8.0.x into branch
| @@ -715,6 +715,9 @@ class NodeGroup(models.Model): | |||
| null=True, | |||
| on_delete=models.CASCADE, | |||
| ) # Allows nodegroups within nodegroups | |||
| graph = models.ForeignKey( | |||
| GraphModel, db_column="graphid", blank=True, null=True, on_delete=models.CASCADE | |||
There was a problem hiding this comment.
Can we make this blank=False in order to add some friction?
| @@ -715,6 +715,9 @@ class NodeGroup(models.Model): | |||
| null=True, | |||
| on_delete=models.CASCADE, | |||
| ) # Allows nodegroups within nodegroups | |||
| graph = models.ForeignKey( | |||
| GraphModel, db_column="graphid", blank=True, null=True, on_delete=models.CASCADE | |||
There was a problem hiding this comment.
Also, null=True doesn't really gel with on_delete=cascade, so if it's only here to support preexisting cruft data, and we already have a major version bump, maybe we just add a command to manage.py validate that deletes cruft nodegroups, and say you have to run that fix before upgrading to 8? WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description of Change
Issues Solved
Closes #11396
Checklist
Accessibility Checklist
Developer Guide
Ticket Background
Further comments