Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.13 compatibility and bump psycopg2 #11550

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

johnatawnclementawn
Copy link
Member

@johnatawnclementawn johnatawnclementawn commented Oct 16, 2024

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

Bumps psycopg2 dependency for compatibility with python 3.13. Ran into an issue similar to that described here: psycopg/psycopg2#1692

Issues Solved

Closes #

Checklist

  • I targeted one of these branches:
    • dev/8.0.x (under development): features, bugfixes not covered below
    • dev/7.6.x (main support): regressions, crashing bugs, security issues, major bugs in new features
    • dev/6.2.x (extended support): major security issues, data loss issues
  • I added a changelog in arches/releases
  • I submitted a PR to arches-docs (if appropriate)
  • Unit tests pass locally with my changes
  • I added tests that prove my fix is effective or that my feature works
  • My test fails on the target branch

Accessibility Checklist

Developer Guide

Topic Changed Retested
Color contrast
Form fields
Headings
Links
Keyboard
Responsive Design
HTML validation
Screen reader

Ticket Background

Further comments

@jacobtylerwalls
Copy link
Member

Nice. Since you've got arches running on 3.13 now, let's do a few more things to declare support for it in general:

  • add the Trove classifier for 3.13 to pyproject.toml (just copy/adjust the one for 3.12)
  • add 3.13 to the tested versions on CI in the github action (and project template copy)
  • add a little release note in 8.0.0.md
  • adjust pr title

@johnatawnclementawn johnatawnclementawn changed the title Bump psycopg2 Add Python 3.13 compatibility and bump psycopg2 Oct 17, 2024
@jacobtylerwalls jacobtylerwalls merged commit 656d006 into dev/8.0.x Oct 17, 2024
7 checks passed
@jacobtylerwalls jacobtylerwalls deleted the bump_psycopg2 branch October 17, 2024 15:23
@jacobtylerwalls jacobtylerwalls removed their assignment Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants