Generate static urls #11571
Generate static urls #11571
Conversation
| @@ -22,7 +22,7 @@ | |||
| <!DOCTYPE html> | |||
| <!--[if IE 8]> <html lang="en" class="ie8"> <![endif]--> | |||
| <!--[if IE 9]> <html lang="en" class="ie9"> <![endif]--> | |||
| <!--[if !IE]><!--> <html lang="en"> <!--<![endif]--> | |||
| <!--[if !IE]><!--> <html lang="{{ app_settings.ACTIVE_LANGUAGE }}"> <!--<![endif]--> | |||
There was a problem hiding this comment.
Thinking about this more since yesterday, this might be alright after all, given the current pattern of using the i18n pattern routes from Django. On language switch, reload the page, see the updated /lang/... route. Hash out a different pattern if/when we need it.
|
|
||
|
|
||
| def _generate_urls_json(): | ||
| def generate_human_readable_urls(patterns, prefix="", namespace="", result={}): |
There was a problem hiding this comment.
I try to avoid mutable default arguments like [] and {}, although I do see you've wrapped this all in a closure. Just wondering if you'd prefer to make this a little more explicit so someone else isn't surprised that result persists between calls.
| "OPTIONS": { | ||
| "options": "-c cursor_tuple_fraction=1", | ||
| }, |
There was a problem hiding this comment.
I had this intended like that for easier copy-pasting, since it's two levels deep. Maybe it's better to keep the indenting and clarify in the verbiage that this is all underneath "default:".
There was a problem hiding this comment.
oh no fair enough, I just ran the doc through a formatter and that popped out. Happy to revert
|
|
||
| 1. Replace the `generate_frontend_configuration` import statement in `apps.py`: | ||
| ``` | ||
| from arches.settings_utils import generate_frontend_configuration |
There was a problem hiding this comment.
I toyed with importing this into the old location so that projects wouldn't need to update, but things broke, so 👍
| @@ -57,6 +58,8 @@ JavaScript: | |||
|
|
|||
| - `ensure_userprofile_exists()` was removed from the `Tile` model. | |||
|
|
|||
| - The `arches` object is no longer available in frontend components that exist outside of defined Arches patterns. If your project contains Vue components that are mounted on templates that inherit directly from `base-root.htm`, they will need to be updated to use `generateArchesURL` and the settings API instead. | |||
There was a problem hiding this comment.
Suggest something a little more specific than "defined patterns", which makes sense to people who read on about base-root.htm and know what that is, but others might need help understanding if this applies to them.
| def join_paths(*args): | ||
| return "/".join(filter(None, (arg.strip("/") for arg in args))) |
There was a problem hiding this comment.
We seem to be losing the trailing slash on some routes. Leaving aside whether it's a good idea to have trailing slashes required in your routes, if projects do have that, I think we should leave it to them (and whatever third-party packages even outside of arches they depend on).
For instance, with status quo, we have on javascript.htm:
reorder_cards="/reorder_cards/"
but now in urls.json:
"reorder_cards": "/reorder_cards",
giving:
> _arches_utils_generate_arches_url_ts__WEBPACK_IMPORTED_MODULE_11__["default"]('reorder_cards')
'/reorder_cards'Which will cause a redirect (or not) depending on the value of APPEND_SLASH and yada yada.
Can we avoid a behavior change here?
Types of changes
Description of Change
This removes dependency on
arches_urls.htmfor all Vue frontend work.Issues Solved
Closes #11567
Checklist
Accessibility Checklist
Developer Guide
Ticket Background
Further comments