Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart Contracts: use decimals right after tokenization #1533

Conversation

bchamagne
Copy link
Member

Description

The problem identified is tested by "floats are precise" unit test.
We fixed it by transforming all floats into %Decimals{}. Most of the code changed is to allow for decimals in the stdlib.

  • write unit tests on lib functions that may return floats (Chain.get_balance etc)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Unit tested

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bchamagne bchamagne added bug Something isn't working smart contracts Involve smart contracts labels Jun 17, 2024
@bchamagne
Copy link
Member Author

Closing due to the impact in performance and the fact that it does not fix the problem 100% because we still have an API in json.

@bchamagne bchamagne closed this Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working smart contracts Involve smart contracts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant