-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate bls signature scheme #1541
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelmanzanera
added
feature
New feature request
P2P
Involve P2P networking
crypto
Involve cryptography
labels
Jul 19, 2024
samuelmanzanera
changed the title
Integrate bls public keys
Integrate bls signature scheme
Jul 19, 2024
samuelmanzanera
force-pushed
the
integrate_bls
branch
from
July 22, 2024 08:00
8568e8b
to
2458689
Compare
samuelmanzanera
force-pushed
the
integrate_bls
branch
from
July 22, 2024 16:16
4f2e7e2
to
2535205
Compare
bchamagne
approved these changes
Aug 29, 2024
Neylix
requested changes
Sep 5, 2024
Neylix
reviewed
Sep 6, 2024
Co-authored-by: Neylix <[email protected]>
Co-authored-by: Neylix <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support of BLS mining public key
Note: I inserted a migration task which not run by default.
This task should be run after the upgrade have been released.
Fixes #1519
Fixes #1542
Type of change
How Has This Been Tested?
Test have been released with multiple nodes with upgrades of nodes.
In memory table should be updated.
Starting from develop and then to this branch.
Run the migration script to create a new transaction with the mining public key
Restart tests have been made to make sure the node's transaction content decoding is backward compatible
Explorer should list the new mining public key from the node info and from the node's transaction content
Checklist: