Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate bls signature scheme #1541

Merged
merged 11 commits into from
Sep 9, 2024
Merged

Integrate bls signature scheme #1541

merged 11 commits into from
Sep 9, 2024

Conversation

samuelmanzanera
Copy link
Member

@samuelmanzanera samuelmanzanera commented Jul 19, 2024

Description

Add support of BLS mining public key

Note: I inserted a migration task which not run by default.
This task should be run after the upgrade have been released.

Fixes #1519
Fixes #1542

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Test have been released with multiple nodes with upgrades of nodes.
In memory table should be updated.
Starting from develop and then to this branch.

Run the migration script to create a new transaction with the mining public key

Restart tests have been made to make sure the node's transaction content decoding is backward compatible

Explorer should list the new mining public key from the node info and from the node's transaction content

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@samuelmanzanera samuelmanzanera added feature New feature request P2P Involve P2P networking crypto Involve cryptography labels Jul 19, 2024
@samuelmanzanera samuelmanzanera changed the title Integrate bls Integrate bls public keys Jul 19, 2024
@samuelmanzanera samuelmanzanera changed the title Integrate bls public keys Integrate bls signature scheme Jul 19, 2024
lib/archethic/crypto.ex Outdated Show resolved Hide resolved
lib/archethic/p2p/node.ex Outdated Show resolved Hide resolved
lib/archethic/p2p/node.ex Outdated Show resolved Hide resolved
lib/archethic/p2p/node.ex Outdated Show resolved Hide resolved
lib/archethic/p2p/node.ex Outdated Show resolved Hide resolved
@Neylix Neylix merged commit c20c6a0 into develop Sep 9, 2024
5 checks passed
@Neylix Neylix deleted the integrate_bls branch September 9, 2024 09:17
@Neylix Neylix restored the integrate_bls branch September 9, 2024 09:17
@Neylix Neylix deleted the integrate_bls branch September 9, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Involve cryptography feature New feature request P2P Involve P2P networking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update node's transaction to support BLS's public key publication Support BLS signature scheme
3 participants