arch-chroot: bind mount over a /etc/resolv.conf symlink #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Foxboron
approved these changes
Aug 6, 2023
|
Maybe also bump the required util-linux version in README? |
To 2.39.1? |
Use mount's a -c/--no-canonicalize option to ensure the bind mount to /etc/resolv.conf in the chroot directory is mounted correctly. This avoids issues when the chroot's /etc/resolv.conf is a symlink. Bump required util-linux version to 2.39 which supports the new mount API. Fixes https://github.com/archlinux/arch-install-scripts/issues/55 Related to util-linux/util-linux#2370
|
Looking at https://lore.kernel.org/util-linux/20230522.064845.1518051418018369671.yamato%40redhat.com/T/, I guess it's 2.39. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
mount's a-c/--no-canonicalizeoption to ensure the bind mount to/etc/resolv.confin the chroot directory is mounted correctly. This avoids issues when the chroot's/etc/resolv.confis a symlink.Fixes https://github.com/archlinux/arch-install-scripts/issues/55
Related to util-linux/util-linux#2370