feat: new export for stuck packets #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is used to have metrics about IBC channel, now just have stuck packets
this splits one total metric so that it will produce three metrics, src,dst and total
jlehtimaki
force-pushed
the
netx-78-expor-stuck-packets
branch
from
da69e26
to
fac6c90
Compare
kayano
reviewed
Oct 27, 2023
kayano
reviewed
Oct 30, 2023
kayano
reviewed
Oct 30, 2023
kayano
reviewed
Oct 30, 2023
kayano
reviewed
Oct 30, 2023
kayano
reviewed
Oct 30, 2023
kayano
reviewed
Oct 30, 2023
kayano
reviewed
Oct 30, 2023
jlehtimaki
force-pushed
the
netx-78-expor-stuck-packets
branch
from
248ac90
to
839bdaa
Compare
kayano
approved these changes
Oct 31, 2023
this removes the need of having two identical checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add new IBC export for IBC channel which will include stuck/pending packets metric.
Also renaming/combining
IBCClientsCollectortoIBCCollectorto use only one collector for all IBC related metrics.