Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): respect multiple request body types #360

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

ardatan
Copy link
Owner

@ardatan ardatan commented Jul 19, 2023

No description provided.

@github-actions
Copy link
Contributor

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
fets 0.4.5-alpha-20230719173913-3eeac8c npm ↗︎ unpkg ↗︎

@ardatan ardatan merged commit 098806a into master Jul 19, 2023
20 checks passed
@ardatan ardatan deleted the respect-multiple-request-types branch July 19, 2023 17:41
@github-actions
Copy link
Contributor

💻 Website Preview

The latest changes are available as preview in: https://0b3d8d91.fets.pages.dev

@github-actions
Copy link
Contributor

✅ Benchmark Results

     ✓ no_errors{server:node-http,mode:no-schema}
     ✓ expected_result{server:node-http,mode:no-schema}
     ✓ no_errors{server:node-http,mode:json-schema}
     ✓ expected_result{server:node-http,mode:json-schema}
     ✓ no_errors{server:node-http,mode:zod}
     ✓ expected_result{server:node-http,mode:zod}
     ✓ no_errors{server:uWebSockets,mode:no-schema}
     ✓ expected_result{server:uWebSockets,mode:no-schema}
     ✓ no_errors{server:uWebSockets,mode:json-schema}
     ✓ expected_result{server:uWebSockets,mode:json-schema}
     ✓ no_errors{server:uWebSockets,mode:zod}
     ✓ expected_result{server:uWebSockets,mode:zod}

     checks......................................: 100.00% ✓ 758228      ✗ 0     
     data_received...............................: 69 MB   382 kB/s
     data_sent...................................: 47 MB   263 kB/s
     http_req_blocked............................: avg=2.61µs   min=1.4µs   med=2.1µs   max=2.05ms  p(90)=2.9µs   p(95)=4.1µs   
     http_req_connecting.........................: avg=9ns      min=0s      med=0s      max=1.84ms  p(90)=0s      p(95)=0s      
     http_req_duration...........................: avg=333.14µs min=170.5µs med=280.6µs max=29.77ms p(90)=376.4µs p(95)=454.4µs 
       { expected_response:true }................: avg=333.14µs min=170.5µs med=280.6µs max=29.77ms p(90)=376.4µs p(95)=454.4µs 
     ✓ { server:node-http,mode:json-schema }.....: avg=359.39µs min=210.5µs med=302.7µs max=15.72ms p(90)=410.2µs p(95)=500.31µs
     ✓ { server:node-http,mode:no-schema }.......: avg=337.77µs min=192.6µs med=277.9µs max=29.11ms p(90)=396.4µs p(95)=480.72µs
     ✓ { server:node-http,mode:zod }.............: avg=349.82µs min=212.3µs med=301.1µs max=18.05ms p(90)=400.7µs p(95)=486.2µs 
     ✓ { server:uWebSockets,mode:json-schema }...: avg=328.1µs  min=191.1µs med=273.1µs max=23.58ms p(90)=357.1µs p(95)=423.1µs 
     ✓ { server:uWebSockets,mode:no-schema }.....: avg=302.09µs min=170.5µs med=252.6µs max=18.1ms  p(90)=328µs   p(95)=388.71µs
     ✓ { server:uWebSockets,mode:zod }...........: avg=326.97µs min=192.6µs med=273.6µs max=29.77ms p(90)=355.3µs p(95)=421.1µs 
     http_req_failed.............................: 0.00%   ✓ 0           ✗ 379114
     http_req_receiving..........................: avg=31.68µs  min=14.3µs  med=26.5µs  max=18.9ms  p(90)=40.3µs  p(95)=45.9µs  
     http_req_sending............................: avg=15.2µs   min=8µs     med=11.1µs  max=8.11ms  p(90)=20.5µs  p(95)=25.7µs  
     http_req_tls_handshaking....................: avg=0s       min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s      
     http_req_waiting............................: avg=286.24µs min=140.2µs med=238.9µs max=29.65ms p(90)=322.4µs p(95)=393.3µs 
     http_reqs...................................: 379114  2106.155341/s
     iteration_duration..........................: avg=466.08µs min=255.7µs med=405.4µs max=30.05ms p(90)=532.3µs p(95)=626.7µs 
     iterations..................................: 379114  2106.155341/s
     vus.........................................: 1       min=1         max=2   
     vus_max.....................................: 2       min=2         max=2   

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant