Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed response wait time from 10 000 to 120 000 #108

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lorithai
Copy link

Documentation specifies that the wait response timer could be as high as 120 000ms for the USOCL AT command. When USOCL was called and the response time was higher than the previously set time of 10 000ms the MKRNB 1500 freezes.

The changes were done to the NBClient.cpp's MODEM.waitForResponse. This fixed the issue of the MKRNB 1500 freezing while issuing the USOCL command in some cases.

There are more instances of MODEM.waitForResponse in other files, but it is unknown to me if these are calling the USOCL command.

Documentation specifies that the wait response timer could be as high as 120 000ms. When USOCL was called that the response time was higher than the previously set time of 10 000ms the MKRNB 1500 freezes.
@CLAassistant
Copy link

CLAassistant commented Feb 20, 2023

CLA assistant check
All committers have signed the CLA.

@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants