Set NB default restart value to false #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Memory usage change @ f0682af
Click for full report table
Click for full report CSV |
aentinger
reviewed
Feb 10, 2021
| if (restart) { | ||
| shutdown(); | ||
| end(); | ||
| delay(1500); |
There was a problem hiding this comment.
Two thinks are on my mind here:
- Isn't there a
hardResetdoing pretty much the same what you are doing here? (Add hardReset() #64) - It has come up that the real relay should be rather 10 s than 1.5 (Fix hardReset method to match the datasheet #70)
There was a problem hiding this comment.
No, this is a soft reset. The hardReset() method is a final resort if nothing else works. It may brick the modem.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to fix #71.
The modem used to behave properly only when using
nbAccess.begin(PINNUMBER, APN, USERNAME, PASSWORD, false, true), which does not restart the modem.By changing in the library the default value of
restartfrom true to false, the modem behaves correctly without specifying the last two input parameters:nbAccess.begin(PINNUMBER, APN, USERNAME, PASSWORD).