Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added getYPR, getYPRRadians and getQuaternion. Possible usage for variable integration steps. #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

afrancescon
Copy link

Added convenient method to access yaw, pitch and roll in one call (helps in some to keep code clear).

Added getQuaternion to access internal quaternion where needed.

@afrancescon afrancescon changed the title Added getYPR, getYPRRadians and getQuaternion methods Added getYPR, getYPRRadians and getQuaternion. Possible usage for variable integration steps. Nov 26, 2017
@afrancescon
Copy link
Author

I further added update methods with time (in millis) argument. This can be helpful when integration time is not fixed but can vary due to other MCU activities. I put attention to keep signature back-compatible.

Copy link

@facchinm facchinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of typos (like ellapsedTime -> should be elapsedTime).
The signatures on keywords.txt do not match the actual functions (getYPR -> getRPY).
About the latter, we usually avoid providing APIs that accept pointers, so it would be better to pass the values by reference (or creating a RollPitchYaw object and returning it if "atomic" operations is required)

@per1234 per1234 mentioned this pull request Mar 14, 2020
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants