Fixed case-insensitive name check in checkSketchFile #11554
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes #8030
It turns out that on case-insensitive file systems, the "file.exists" check will return true even if the file that actually exists differs from the file being checked in the case of the letters. (i.e. "Test.ino" will be considered to exist even if the actual file name is "test.ino").
The proposed solution is to make use of the function getCanonicalFile as suggested in this StackOverflow answer to get the actual file name and compare it to the expected name.
I decided to implement a function in FileUtils for better code reuse but it could have been inlined as well since this is its only use-case currently.
All Submissions:
Changes to Core Features: