Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the link script to optimum the RAM layout #401

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change the link script to optimum the RAM layout #401

wants to merge 1 commit into from

Conversation

sgbihu
Copy link
Contributor

@sgbihu sgbihu commented Jan 16, 2017

  1. Revert the DCCM change
  2. Update the link script

@kitsunami kitsunami added this to the Deneb milestone Jan 17, 2017
eriknyquist
eriknyquist reviewed Jan 26, 2017
View reviewed changes
variants/arduino_101/linker_scripts/flash.ld
@@ -40,8 +40,8 @@ OUTPUT_FORMAT("elf32-littlearc", "elf32-bigarc", "elf32-littlearc")
MEMORY
{
FLASH (rx) : ORIGIN = 0x40034000, LENGTH = 152K
SRAM (wx) : ORIGIN = 0xa800e000, LENGTH = 24K
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought "rwx" and "wx" were the same thing (i.e. "w" signifies both read and write). I'm not 100% sure though. Can somebody explain why this is needed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping.... any answers to my question above?

@kitsunami
Copy link

This is a performance improvement that will go into the next release.

@kitsunami kitsunami modified the milestones: Elnath, Deneb Feb 22, 2017
eriknyquist
eriknyquist suggested changes Feb 22, 2017
View reviewed changes
variants/arduino_101/linker_scripts/flash.ld
__dccm_start = .;
*(.kernelmempool)
*(".kernelmempool.*")
__dccm_end = ALIGN(4);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this does not actually align the location counter-- it calculates the next aligned value based on the current location counter, although the counter itself remains unaligned. I think you should do something like this instead;

. = ALIGN(4);
__dccm_end = .;

@sgbihu
Change the link script to optimum the RAM layout
3f4c4f7 
1. Revert the DCCM change
2. Update the link script
@kitsunami kitsunami removed this from the Elnath milestone Aug 30, 2017
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriknyquist eriknyquist eriknyquist requested changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sgbihu @kitsunami @CLAassistant @eriknyquist @SidLeung