V4.2 Porting #534
Open
V4.2 Porting #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -392,7 +400,7 @@ class BLEDeviceManager | |||
| uint8_t _peer_adv_data[BLE_MAX_ADV_BUFFER_CFG][BLE_MAX_ADV_SIZE]; | |||
| uint8_t _peer_adv_data_len[BLE_MAX_ADV_BUFFER_CFG]; | |||
| uint8_t _peer_scan_rsp_data[BLE_MAX_ADV_BUFFER_CFG][BLE_MAX_ADV_SIZE]; | |||
| int8_t _peer_scan_rsp_data_len[BLE_MAX_ADV_BUFFER_CFG]; | |||
| uint8_t _peer_scan_rsp_data_len[BLE_MAX_ADV_BUFFER_CFG]; | |||
There was a problem hiding this comment.
This change has been considered. Your implementation has an assumption, the scan response should followed by advertisement. But this may has some corner case to make ADV not be reported to sketch.
Now I use timeout mechanism. The central will report ADV data after 800ms delay.
Solution: Add service and appearance characteristic in the BLE lib. Changed files BLEDevice.cpp - check the local device BLEDeviceManager.cpp - Change the calls BLEDeviceManager.h - remove appearance member BLEProfileManager.cpp - Add GAP service and appearance characteristic BLEProfileManager.h - Add set/get API
Make the BLE support more characteristics and services by separate the service registration Changed files BLEProfileManager.cpp - Remove register all service at same time BLEProfileManager.h - Change the comments BLEServiceImp.cpp - Add the register service after update the characteristic
Root cause 1. The return value indecate the read/write request send successfully. 2. The subscribe will ignore the response and this will not be fixed. Solution 1. Add the error detect based on read/write response. Changed files BLECallbacks.cpp - Delete the error check for read response. BLECharacteristicImp.cpp - Add the error check. - Optimize the memory allocate and clear the allocated memory. BLECharacteristicImp.h - Add varibles to flag the response error
1. Implement the subscribe changed event notify feature. Changed files: BLECallbacks.cpp - Add subscribe changed handler and disconnect process BLECallbacks.h - Callback declaration BLECharacteristicImp.cpp - Add the event changed handler BLECharacteristicImp.h - Handler declaration
1. Subscribe/unsubscribe event cause notification can't send out 2. Delete unused code 3. Update the library.
1. Reconstruct the initial process to avoid call BLE API Changed files BLEDeviceManager.cpp - Change the init order ble_client.c - Add new call ble_service.h - Add new API declaration ble_service.c - Modify init logic ble_service_api.c - Delete unsed file nble_driver.c - Modify init logic
1. Fix Jira 769/git arduino#378. Discover GAP service by parameter. 2. Fix Jira 770/git arduino#379 to show the device name in central when discover GAP service. Changed service BLEDevice.cpp - Modify the API BLEDevice.h - Modify the API BLEDeviceManager.cpp - Add get device name logic BLEProfileManager.cpp - Implement get devicename and dicovery logic BLEProfileManager.h - Add API to get devicename from characteristic BLEServiceImp.cpp - Modify the filter logic BLEServiceImp.h - Modify the API
…nexpected
Root cause:
1. The stack doesn't release the resource and makes peripheral crashed.
Then central blocked.
Solution:
1. Fix memory leak issue and release the resource.
Changed File:
gatt.c - Modify the code to make sure the resource can be released.
1. Dismiss the warnings. 2. Rebuild the library Changed files: BLEProfileManager.cpp - Init member variable rpc_deserialize.c - Delete unreachable code dtm.c - Init the variables gap.c - Init the variables gatt.c - Init the variables
1. Reinitial the BLE MAC address to avoid BLE start timer
Root cause 1. The central powered off peripherial device and make it not give response. Solution 1. Exit the wait loop when connection lost. Changed file BLECharacteristicImp.cpp - Change the wait logic
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting V4.2 to improve the performance. Please don't merge.