Slim down sketch size #553
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
__assert_func and its dependencies are automatically added by libc unless we provide a stub implementation and avoid uisng -Wl,--whole-archive when linking against system lib
By moving the BLE stack initialization to its library we can avoid including it in any build.
eriknyquist
reviewed
May 19, 2017
| @@ -158,6 +158,9 @@ SECTIONS | |||
| { | |||
| . = ALIGN(4); | |||
| __start_heap = .; | |||
| end = __start_heap; | |||
| _end = end; | |||
| __end = end; | |||
There was a problem hiding this comment.
I'm not clear on the purpose of these 3 new symbols? can you explain them?
There was a problem hiding this comment.
This is the first step to properly support newlib's nano.specs, which unfortunately aren't compiled in the current toolchain. The nano lib doesn't provide all the symbols and the linker would fail with something like
sbrk.c:(.text._sbrk+0x2): undefined reference to `end'
|
@SidLeung can you review please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 0304de7 the sketch size has exploded. Moving the BLE stack to ARC core is the main responsible.
This patch addresses two main fields:
The first patch could be further optimized but since most sketches uses the CDC port it doesn't make much sense.
Sketch size comparison:
BareMinimum: 48744 -> 12540
(BLE central) Scan: 91692 -> 80440