Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the Wire.flush() funtion #773

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

watershade
Copy link

  1. implement flush of wire. (flush functions have never been implemented before. But it is useful.)

1. implement flush of wire.
(flush functions have never been implemented before. But it is useful.)
@watershade
Copy link
Author

Wire.flush() is useful, if I haven't read obsolete data from it. I will get a wrong number via Wire.available() because the size have include the obsolete data. And If I use Wire.read(), the data I read out is include the obsolete data also. Yes, I can read the obsolete data out via Wire.read(), but it is not necessary. If Wire.flush() is I implemented, It will become perfect.
Thanks!

@watershade
Copy link
Author

@facchinm Hi Martino, I don't know if you time to check this merge. Thanks.

@tokiedokie
Copy link
Contributor

Duplicate of #760

@pennam pennam mentioned this pull request Feb 1, 2024
@pennam
Copy link
Contributor

pennam commented Feb 1, 2024

Flush should be intended as a way to send all data out of the TX buffer not to cleanup the RX. See Serial.flush() https://www.arduino.cc/reference/it/language/functions/communication/serial/flush/

@tokiedokie
Copy link
Contributor

Should the RX buffer cleanup API be called clear()?

@pennam
Copy link
Contributor

pennam commented Feb 1, 2024

Should the RX buffer cleanup API be called clear()?

I don't think there is a standard Arduino API, but personally i think is a more appropriate name.

@watershade
Copy link
Author

watershade commented Feb 3, 2024

@pennam Thanks for your reply.

I remember flush really flush all data away in old Arduino version.

Prior to Arduino 1.0, this instead removed any buffered incoming serial data.

I will check the new version and try to find a better name. Maybe clear and it is just like @tokiedokie have said .

Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants