Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pin value change on arbitrary condition #721

Closed

Conversation

louisrubet
Copy link

@louisrubet louisrubet commented Oct 4, 2024

Removes the change of the pin argument on a condition depending on A0

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Collaborator

@matthijskooijman matthijskooijman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment in #720, I do not think this is a change that can be made without breaking a ton of backward compatibility.

@louisrubet
Copy link
Author

Touches a lot of existing code, abandoned.

@louisrubet louisrubet closed this Oct 4, 2024
@louisrubet louisrubet deleted the analogRead-remove-pin-condition branch October 4, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants