Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update name and URL of "SimpleControl" #3490

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Update name and URL of "SimpleControl" #3490

merged 3 commits into from
Oct 25, 2023

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Oct 21, 2023

This PR consists of two changes:

  • Change URL from https://github.com/Tenveis/SimpleMotorControl.git to https://github.com/Tenveis/SimpleControl.git
  • Change name from SimpleMotorControl to SimpleControl

Since the name change operation on the database is actually a removal followed by automated re-indexing on the next job run, the URL update will occur as a matter of course. For this reason, the only operation required from the backend maintainer is a standard name change procedure.

companion to #3489

@per1234 per1234 added topic: URL change Change library repository URL topic: rename Change registered library name status: pending backend Depends on backend maintenance operations labels Oct 21, 2023
@MatteoPologruto MatteoPologruto self-assigned this Oct 25, 2023
MatteoPologruto
MatteoPologruto approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@MatteoPologruto MatteoPologruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done:

2023/10/25 16:07:32 Loaded 6304 libraries from DB
Removing SimpleMotorControl
Success!

@MatteoPologruto MatteoPologruto merged commit c2812fe into arduino:production Oct 25, 2023
2 checks passed
@MatteoPologruto MatteoPologruto added the conclusion: resolved Issue was resolved label Oct 25, 2023
@per1234 per1234 deleted the update-SimpleControl branch November 9, 2023 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatteoPologruto MatteoPologruto MatteoPologruto approved these changes

Assignees

@MatteoPologruto MatteoPologruto

Labels
conclusion: resolved Issue was resolved status: pending backend Depends on backend maintenance operations topic: rename Change registered library name topic: URL change Change library repository URL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@per1234 @MatteoPologruto