Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0.2 #5506

Closed
wants to merge 6 commits into from
Closed

1.0.2 #5506

wants to merge 6 commits into from

Conversation

RASPIAUDIO
Copy link
Contributor

Copy link
Contributor

github-actions bot commented Dec 2, 2024

A problem was found with your submission https://github.com/RASPIAUDIO/Muse_library

ERROR: Submission URL is already in the Library Manager index.

@github-actions github-actions bot added the topic: submission Add library to the list label Dec 2, 2024
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Thanks for your interest in contributing to the Arduino Library Manager index @RASPIAUDIO
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

Copy link
Contributor

github-actions bot commented Dec 2, 2024

A problem was found with your submission https://github.com/RASPIAUDIO/Muse_library

ERROR: Submission URL is already in the Library Manager index.

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Thanks for your interest in contributing to the Arduino Library Manager index @RASPIAUDIO
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Hi @RASPIAUDIO.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot added topic: other Something other than a library list request and removed topic: submission Add library to the list labels Dec 2, 2024
@github-actions github-actions bot requested a review from per1234 December 2, 2024 18:01
@RASPIAUDIO
Copy link
Contributor Author

@ArduinoBot

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Hello! I'm checking your submission again.

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Hi @RASPIAUDIO.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot added topic: submission Add library to the list and removed topic: other Something other than a library list request labels Dec 3, 2024
Copy link
Contributor

github-actions bot commented Dec 3, 2024

A problem was found with your submission https://github.com/RASPIAUDIO/Muse_library

ERROR: Submission URL is already in the Library Manager index.

@github-actions github-actions bot removed the request for review from per1234 December 3, 2024 09:11
@RASPIAUDIO
Copy link
Contributor Author

@ArduinoBot

@github-actions github-actions bot requested a review from per1234 December 3, 2024 09:11
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Hello! I'm checking your submission again.

@github-actions github-actions bot removed the request for review from per1234 December 3, 2024 09:12
Copy link
Contributor

github-actions bot commented Dec 3, 2024

A problem was found with your submission https://github.com/RASPIAUDIO/Muse_library

ERROR: Submission URL is already in the Library Manager index.

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Thanks for your interest in contributing to the Arduino Library Manager index @RASPIAUDIO
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions github-actions bot added topic: other Something other than a library list request and removed topic: submission Add library to the list labels Dec 3, 2024
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Hi @RASPIAUDIO.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot requested a review from per1234 December 3, 2024 13:32
@per1234 per1234 self-assigned this Dec 4, 2024
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RASPIAUDIO
❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗
⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️
⚠️ PLEASE READ THIS IMPORTANT INFORMATION ⚠️
⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️
❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗
@RASPIAUDIO

DID YOU READ MY PREVIOUS MESSAGE?????

#5496 (review)

If not, then you need to get your act together and start paying attention!!!!!!!!!!!!!!!!!!

If you did, then why on earth did you submit yet another worthless pull request???????

If you continue to behave disrespectfully you will be permanently banned from the Arduino Library Manager and your library will be removed.

Start acting like a professional instead of an incompetent!!!!!!!!

@per1234 per1234 closed this Dec 4, 2024
@per1234 per1234 added the conclusion: invalid Issue/PR not valid label Dec 4, 2024
@RASPIAUDIO
Copy link
Contributor Author

@RASPIAUDIO
❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗
⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️
⚠️ PLEASE READ THIS IMPORTANT INFORMATION ⚠️
⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️
❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗

@per1234

Thank you for your feedback. I’d like to clarify the sequence of events regarding our pull requests:

  1. The first PR on November 29, 2024, was submitted to add our URL.
  2. The second PR was accidental, as it unintentionally modified one character in the README.md file, which triggered a manual review. My apologies for this oversight.
  3. The third PR was an attempt to correct the README.md to prevent rejection. If there’s a better approach I should have taken, I’d be grateful for your guidance.

I sincerely apologize for any inconvenience or frustration caused. As we are all learning and striving to contribute constructively, I assure you our intentions are genuine and in good faith.

That said, I believe maintaining professionalism in our communication is essential. Referring to someone as "unprofessional" or "incompetent" may not foster the constructive environment we all value in the open-source community.

Thank you for your time and consideration. I’ll make sure to be more thorough in the future.

@RASPIAUDIO
Copy link
Contributor Author

@ArduinoBot

@per1234
Copy link
Contributor

per1234 commented Dec 6, 2024

Hello @RASPIAUDIO. The automated system here only operates on open pull requests. Since the pull request is closed, the bot won't pay any more attention to it.

But this human is happy to provide assistance. Was there something you needed from the bot?

@RASPIAUDIO
Copy link
Contributor Author

RASPIAUDIO commented Dec 8, 2024

Hello @RASPIAUDIO. The automated system here only operates on open pull requests. Since the pull request is closed, the bot won't pay any more attention to it.

But this human is happy to provide assistance. Was there something you needed from the bot?

Thank you for your help, @per1234.

Our library was indeed accepted in PR #5492, but it seems that the latest version (1.0.3), committed to our library repository, is not being updated automatically in the library manager.

I was under the impression that the crawler would automatically fetch new versions. Could you kindly clarify what might be causing this issue?

@per1234
Copy link
Contributor

per1234 commented Dec 8, 2024

Hi @RASPIAUDIO. You can check on the indexing of a library by the automated system by looking at the dedicated logs web page for the library. The logs page for this library is here:

https://downloads.arduino.cc/libraries/logs/github.com/RASPIAUDIO/Muse_library/

2024/12/08 14:40:13 Checking out tag: v1.0.2
2024/12/08 14:40:13 Release :1.0.2 has wrong library name, should be Muse_library
2024/12/08 14:40:13 Checking out tag: v1.0.3
2024/12/08 14:40:14 Release :1.0.3 has wrong library name, should be Muse_library

The indexer rejects any release that does not meet the requirements. The 1.0.2 and 1.0.3 releases of the library do not meet the requirements, so they were rejected by the indexer.

At the time you registered the library, the metadata was valid:

https://github.com/RASPIAUDIO/Muse_library/blob/v1.0.0/library.properties#L1

name=Muse_library

However, a corruption was later introduced:

RASPIAUDIO/Muse_library@e8c84d2

--- a/library.properties
+++ b/library.properties
@@ -1,4 +1,4 @@
-name=Muse_library
+sp32-sh1106-oledname=Muse_library
 version=1.0.1
 author=Raspiaudio
 maintainer=Raspiaudio <[email protected]>

You changed the property name from name to sp32-sh1106-oledname. This effectively removed the definition of the library name from the metadata.

To solve this, you should do the following:

  1. Change the name of the sp32-sh1106-oledname property in library.properties back to name.
  2. Update the value of the version property to the number you want to use for the new release (e.g., 1.0.4)
  3. Make a new release or tag in the library repository.

After that, you only need to wait for the indexer job to run, and then for the updated index to propagate to you and the library users. After a successful indexing, it does take a bit of time before you will see a new release in your Library Manager due to caching, but it will get there eventually. We give a conservative estimate of availability within one day's time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: invalid Issue/PR not valid topic: other Something other than a library list request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants