Add emulation radio and hidden file checkbox labels #22432
Conversation
| @@ -2315,7 +2315,7 @@ void HandleOtherConfiguration(void) { | |||
| if (i == EMUL_HUE) { i++; } | |||
| #endif | |||
| if (i < EMUL_MAX) { | |||
| WSContentSend_P(PSTR("<input id='r%d' name='b2' type='radio' value='%d'%s><b>%s</b> %s<br>"), // Different id only used for labels | |||
| WSContentSend_P(PSTR("<label><input id='r%d' name='b2' type='radio' value='%d'%s><b>%s</b> %s</label><br>"), // Different id only used for labels | |||
There was a problem hiding this comment.
I'm not sure what the "Different id only used for labels" comment refers to. Did not find where the ids would be used, and there were no labels before this PR.
There was a problem hiding this comment.
Why would we need to enclose all this in <label>?
|
Wasting code space without adding functionality. |
|
The whole point of this PR is that it does add functionality. After wrapping the radio button or checkbox with its label, one can click on the label text to activate the wrapped radio/checkbox, so one does not have to so accurately aim at the small radio/checkbox itself. Further, all other checkboxes and radio buttons that I could find besides ones in this PR are already wrapped in Please reconsider and reopen. |
Description:
Related issue (if applicable): fixes #
Add
<label>elements to radio buttons and checkboxes that are missing one.Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass