Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shutter] Fix UI inverted mode #22538

Merged
merged 1 commit into from
Nov 23, 2024
Merged

Conversation

SteWers
Copy link
Contributor

@SteWers SteWers commented Nov 23, 2024

Description:

Fix UI for shutter in inverted mode

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.8
  • The code change is tested and works with Tasmota core ESP32 V.3.1.0.241117
  • I accept the CLA.

Fix UI for shutter in inverted mode
@arendst
Copy link
Owner

arendst commented Nov 23, 2024

Was this an issue before the new GUI was introduced too?

@SteWers
Copy link
Contributor Author

SteWers commented Nov 23, 2024

May be. There were several issues with the inverted mode, as you have to think completely in the other direction. Something felt wrong, when I saw the new (very nice) UI. So I investigated both modes. Normal mode worked correct.
In line 1436 was the wrong flag requested for inverted mode. After changing it, the buttons were displayed at the right position, but commanding the wrong direction. The rest of the code is for solving that. Now it works in both modes, but maybe there is a "nicer" way to solve it.

@arendst
Copy link
Owner

arendst commented Nov 23, 2024

Let's ask @stefanbode what he thinks is the correct solution.

@SteWers
Copy link
Contributor Author

SteWers commented Nov 23, 2024

Good idea.
I had a quick look at the release 14.3.0. The buttons were not swapped. As they were not near to the slider, it was no problem.
image
(Shutter 1 is not inverted, shutter 2 is inverted)

But now the slider should move towards the button, which is pressed.
image
(Same configuration as above with the fix applied)

@arendst arendst merged commit 3c703ac into arendst:development Nov 23, 2024
59 checks passed
@SteWers SteWers deleted the Shutter-1 branch November 23, 2024 15:25
@stefanbode
Copy link
Contributor

Great thanks. Agree to all findings. Nice change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants