Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SolaxX1] Energy calculation #22568

Merged
merged 1 commit into from
Dec 1, 2024
Merged

Conversation

SteWers
Copy link
Contributor

@SteWers SteWers commented Nov 30, 2024

Description:

The amount of energy calculated and reported by the inverter is wrong. Maybe this depends on the inverters firmware. This PR gives the opportunity of using the calculation with the driver depending on SetOption72. When it is activated, the values from the inverter are used. When it is off, the driver does the calculation and the inverter values are displayed at the UI for information purposes.

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.8
  • The code change is tested and works with Tasmota core ESP32 V.3.1.0.241117
  • I accept the CLA.

@SteWers SteWers mentioned this pull request Nov 30, 2024
6 tasks
@arendst arendst merged commit 0ea8889 into arendst:development Dec 1, 2024
59 checks passed
@SteWers SteWers deleted the SX1-Energy-1 branch December 1, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants