-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logical flow #71
base: main
Are you sure you want to change the base?
Logical flow #71
Conversation
Hello @samgdotson! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-12-23 18:53:30 UTC |
Summary of changes
This PR adds a new dispatch model to
osier
calledLogicDispatchModel
that follows a hierarchy of rules to dispatch energy. It is much faster (~4x speedup) than the originalDispatchModel
but it is myopic and therefore results may be sub-optimal. Other benefits include:osier
is more self-contained.DispatchModel
. No change to syntax.CapacityExpansion
model.Note
There are a couple of new tests for new functionality. These tests should exceed the minimum code coverage required by the
pyproject.toml
file (75%). More tests are desired, but not necessary, here.Types of changes
Checklist for Reviewers
Reviewers should use this link to get to the
Review Checklist before they begin their review.