-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression Test Pipeline #120
base: main
Are you sure you want to change the base?
Conversation
Abhinay1997
commented
Apr 20, 2024
•
edited by ZachNagengast
Loading
edited by ZachNagengast
- Add English text normlaization.
- Add WER calculations.
- Compare and check norm outputs from Python implementation
- Add WER to the regression tests once Memory and Latency Regression Tests #99 is merged
Code is still messy. Needs cleanup once the normalization starts working. |
Running tests locally. Adding more unit tests for the new normalization code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Abhinay1997 As discussed offline, here are the last few items before we can merge this one:
- Removing example test result JSONs
- Removing the Fraction implementation altogether
- Adding AudioEncoder latency measurements to
LatencyStats
We discussed the following as nice to haves (could defer to a future PR):
- Writing the following static attributes to the resulting JSON:
"static_attributes":
- whisperkit_version (string)
- os (string)
- encoder_compute_units (string)
- decoder_compute_units (string)
- enable_word_timestamps (boolean)
- enable_eager_decoding (boolean)
- enable_vad (boolean)
- silence_threshold
- is_low_power_mode (boolean)
- is_stream_simulated (boolean)
- Periodically (e.g. 1 minute) measuring the following stats in a separate thread and writing the timeseries results to the final JSON:
"system_measurements":
- thermal_state (string)
- device_temperature (int)
- memory_total_available_gb (float)
- memory_total_used_gb (float)
- memory_app_allocated_gb (float)
- memory_app_used_gb (float)
- memory_swap_used_gb (float)
- battery_level (float)
- disk_total_space_gb (float)
- disk_free_space_gb (float)
* Remove Fraction.swift * Remove commented out redundant code
@atiorh made the changes except for the |