Tally filter #108
Merged
Tally filter #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DonAurelio and @Kerilk ready for you review guys. |
added 2 commits
July 7, 2023 16:36
Kerilk
reviewed
Jul 7, 2023
|
In this branch, we are still having this #101 issue, seems the solution was not merged properly into this branch |
DonAurelio
reviewed
Jul 10, 2023
DonAurelio
reviewed
Jul 10, 2023
DonAurelio
reviewed
Jul 10, 2023
DonAurelio
reviewed
Jul 10, 2023
DonAurelio
reviewed
Jul 10, 2023
DonAurelio
reviewed
Jul 10, 2023
Co-authored-by: Aurelio Vivas <[email protected]>
Co-authored-by: Aurelio Vivas <[email protected]>
|
We are good to go now |
DonAurelio
approved these changes
Jul 11, 2023
Kerilk
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the splitting of tally into a filter and and a sink.
Needed to add a suffix to the makefile rule to distinguish between sink and filter.
Duplicated some code in the model because handling multiple yaml-model in the makefile was painful. We can fix that later. (not sure how...)
The babeltrace_thapi is definitely ugly, we should re-write it with some better abstraction. But didn't want to pollute the PR with that.